Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the AutoRegistration protobuf message to be more FE friendly #3504

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Jun 3, 2024

Summary

Based on discussion this PR adjusts the AutoRegistration message to be
more FE friendly and clients-friendly in general. The main points are:
- it's easier for the clients to disable auto-registration for an
entity by flipping a boolean to false
- it's easier to extend with more attributes in the future

Related: #3266

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

unit tests

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Based on discussion this PR adjusts the AutoRegistration message to be
more FE friendly and clients-friendly in general. The main points are:
    - it's easier for the clients to disable auto-registration for an
      entity by flipping a boolean to false
    - it's easier to extend with more attributes in the future

Related: mindersec#3266
@jhrozek jhrozek requested a review from a team as a code owner June 3, 2024 10:16
@coveralls
Copy link

Coverage Status

coverage: 52.393% (+0.01%) from 52.382%
when pulling fc67b57 on jhrozek:enroll_config_change
into f96e0ea on stacklok:main.

Copy link
Contributor

@blkt blkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I suggest discussing UX with more people.

@jhrozek jhrozek merged commit a568ecf into mindersec:main Jun 3, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants