Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ContextV2 protobuf structure #3506

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Add ContextV2 protobuf structure #3506

merged 1 commit into from
Jun 4, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Jun 3, 2024

Summary

This takes a project_id by default. It also provides the functionality
to prefer a ContextV2 from a request if it's present and available.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@JAORMX JAORMX requested a review from a team as a code owner June 3, 2024 11:38
@JAORMX JAORMX force-pushed the ctx-v2 branch 2 times, most recently from 3b76e04 to db0f5a4 Compare June 3, 2024 12:09
@coveralls
Copy link

coveralls commented Jun 3, 2024

Coverage Status

coverage: 52.402% (-0.006%) from 52.408%
when pulling 5e2e820 on ctx-v2
into 3afa50e on main.

This takes a `project_id` by default. It also provides the functionality
to prefer a `ContextV2` from a request if it's present and available.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
@JAORMX JAORMX merged commit 237328b into main Jun 4, 2024
21 checks passed
@JAORMX JAORMX deleted the ctx-v2 branch June 4, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants