Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover from panics from the control plane #3519

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Recover from panics from the control plane #3519

merged 2 commits into from
Jun 4, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Jun 4, 2024

Summary

This adds middleware for the GRPC and HTTP handlers so we would only
log panics instead of minder crashing and having to restart. This
ensures that we don't stop serving requests even if something has gone
wrong in our code. We need to start monitoring for panics in the logs
then.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@JAORMX JAORMX requested a review from a team as a code owner June 4, 2024 12:48
blkt
blkt previously approved these changes Jun 4, 2024
@coveralls
Copy link

coveralls commented Jun 4, 2024

Coverage Status

coverage: 52.442% (-0.04%) from 52.48%
when pulling fe361de on recover
into a896873 on main.

This adds middleware for the GRPC and HTTP handlers so we would only
log panics instead of minder crashing and having to restart. This
ensures that we don't stop serving requests even if something has gone
wrong in our code. We need to start monitoring for panics in the logs
then.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
@JAORMX JAORMX merged commit e9e43e9 into main Jun 4, 2024
20 checks passed
@JAORMX JAORMX deleted the recover branch June 4, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants