Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move auth offline-token to a separate package #3522

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Move auth offline-token to a separate package #3522

merged 1 commit into from
Jun 5, 2024

Conversation

rdimitrov
Copy link
Member

Summary

Moves the auth offline-token sub-command to a separate package.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov requested a review from a team as a code owner June 4, 2024 22:24
@rdimitrov rdimitrov self-assigned this Jun 4, 2024
@coveralls
Copy link

Coverage Status

coverage: 52.686% (+0.01%) from 52.676%
when pulling 8e249a6 on auth
into 54d663d on main.

Copy link
Contributor

@puerco puerco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM but if we're adopting a new pattern for this subcommand would it make sense to reorganize the rest of the subcommands? What's the goal with moving this one?

@rdimitrov
Copy link
Member Author

This LGTM but if we're adopting a new pattern for this subcommand would it make sense to reorganize the rest of the subcommands? What's the goal with moving this one?

Do you have one in mind? The ones that act as nested parent commands for other sub-commands are already reorganised - profile status, project role and this one - auth offline-token was the only one I found that was left behind.

Copy link
Contributor

@puerco puerco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe no, you are right. I thought there was something special with this one :)
/lgtm

@rdimitrov rdimitrov merged commit 778e70d into main Jun 5, 2024
21 checks passed
@rdimitrov rdimitrov deleted the auth branch June 5, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants