Migrate existing rule instances into rule_instances table #3534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmjb
force-pushed
the
migrate-rule-instance-new-table
branch
from
a8e6a81
to
e6f0719
Compare
dmjb
force-pushed
the
migrate-rule-instance-new-table
branch
from
004ca6a
to
e1f55b1
Compare
dmjb
force-pushed
the
migrate-rule-instance-new-table
branch
2 times, most recently
from
0ab4a70
to
f6918ac
Compare
dmjb
changed the title
dmjb
force-pushed
the
migrate-rule-instance-new-table
branch
from
5edf505
to
1cb69a6
Compare
Rule instances are currently stored as serialized protobuf structures in the database, grouped by entity type. A separate join table exists to track the relationship between a profile-entity and the rule types which are used. This arrangement leads to some rather awkward code and database queries making the profile-related code in Minder more complex than it should be. This PR adds in a definition of a dedicated rule instance table. Subsequent PRs will migrate data over to it and then change the codebase to query this table instead of the current tables.
was necessary during my local testing
dmjb
force-pushed
the
migrate-rule-instance-new-table
branch
from
1cb69a6
to
3e03a4e
Compare
rdimitrov
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3486
This PR adds a migration script to move all rule instances created before PR #3486 to the rule_instances table.
Tested locally.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: