Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add database migration for the user_invites table #3536

Merged
merged 9 commits into from
Jun 7, 2024
23 changes: 23 additions & 0 deletions database/migrations/000062_user_invites.down.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
-- Copyright 2024 Stacklok, Inc
--
-- Licensed under the Apache License, Version 2.0 (the "License");
-- you may not use this file except in compliance with the License.
-- You may obtain a copy of the License at
--
-- http://www.apache.org/licenses/LICENSE-2.0
--
-- Unless required by applicable law or agreed to in writing, software
-- distributed under the License is distributed on an "AS IS" BASIS,
-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-- See the License for the specific language governing permissions and
-- limitations under the License.

BEGIN;

-- drop the index on the project column
DROP INDEX IF EXISTS idx_user_invites_project;

-- drop the user_invites table
DROP TABLE IF EXISTS user_invites;

COMMIT;
30 changes: 30 additions & 0 deletions database/migrations/000062_user_invites.up.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
-- Copyright 2024 Stacklok, Inc
--
-- Licensed under the Apache License, Version 2.0 (the "License");
-- you may not use this file except in compliance with the License.
-- You may obtain a copy of the License at
--
-- http://www.apache.org/licenses/LICENSE-2.0
--
-- Unless required by applicable law or agreed to in writing, software
-- distributed under the License is distributed on an "AS IS" BASIS,
-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-- See the License for the specific language governing permissions and
-- limitations under the License.

BEGIN;

CREATE TABLE IF NOT EXISTS user_invites (
code TEXT NOT NULL PRIMARY KEY,
email TEXT NOT NULL,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the index on (email, project) means that we no longer have an index on email. I'd be tempted to re-add this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, you're right! I must have deleted it along the other stuff 🤦‍♂️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pointed out that a UNIQUE(email, project) index would prevent inviting someone to multiple roles in a project, so it was sort of my fault.

role TEXT NOT NULL DEFAULT 'viewer',
project UUID NOT NULL REFERENCES projects(id) ON DELETE CASCADE,
sponsor INTEGER NOT NULL REFERENCES users(id) ON DELETE CASCADE,
created_at TIMESTAMP NOT NULL DEFAULT NOW(),
updated_at TIMESTAMP NOT NULL DEFAULT NOW()
);

-- create an index on the project column
CREATE INDEX IF NOT EXISTS idx_user_invites_project ON user_invites(project);

COMMIT;
10 changes: 10 additions & 0 deletions internal/db/models.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.