Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the now-unused CreateGitHubOAuthProvider #3540

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Jun 5, 2024

Summary

We now use the provided-agnostic code to create a github provider,
introduced in e578bf8, so let's remove
the unused code.

Related: #3263

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

make

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

We now use the provided-agnostic code to create a github provider,
introduced in e578bf8, so let's remove
the unused code.

Related: mindersec#3263
@jhrozek jhrozek requested a review from a team as a code owner June 5, 2024 13:45
@jhrozek jhrozek merged commit e3b4022 into mindersec:main Jun 5, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants