Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minder CLI - New commands for auth invite - list, accept <code> and decline <code> #3551

Merged
merged 6 commits into from
Jun 7, 2024

Conversation

rdimitrov
Copy link
Member

@rdimitrov rdimitrov commented Jun 6, 2024

Summary

The following PR adds new commands for auth invite - list, accept <code> and decline <code>

The command is set to hidden until the backend side is fully implemented.

Fixes: #3550

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@rdimitrov rdimitrov requested a review from a team as a code owner June 6, 2024 12:55
@coveralls
Copy link

Coverage Status

coverage: 53.153% (+0.005%) from 53.148%
when pulling feb8aea on invites-cli
into a21f1dd on main.

dmjb
dmjb previously approved these changes Jun 6, 2024
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov
Copy link
Member Author

@dmjb - Sorry to dismiss your approval but it was suggested to set the commands to hidden until we have the backend fully implemented. It's ready for review again 👍

@coveralls
Copy link

Coverage Status

coverage: 53.153% (+0.01%) from 53.143%
when pulling 10b6225 on invites-cli
into 59c9839 on main.

evankanderson
evankanderson previously approved these changes Jun 6, 2024
cmd/cli/app/auth/invite/invite.go Outdated Show resolved Hide resolved
Co-authored-by: Evan Anderson <evan@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@coveralls
Copy link

Coverage Status

coverage: 53.137% (-0.006%) from 53.143%
when pulling caf1be2 on invites-cli
into 52a5da6 on main.

@rdimitrov rdimitrov merged commit 74b17cf into main Jun 7, 2024
21 checks passed
@rdimitrov rdimitrov deleted the invites-cli branch June 7, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minder CLI - New commands for auth invite - list, accept <code> and decline <code>
5 participants