Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define evaluation history schemas #3565

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Define evaluation history schemas #3565

merged 1 commit into from
Jun 10, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jun 10, 2024

Fixes #3555

Implements the new database schema for storing evaluation history. Compared with the existing tables for profile/rule status, this will track every single evaluation, and not just the most recent state. This will be used to build an API for querying the history of evaluations for a given rule/entity pair.

Queries and logic to fill the tables will be implemented in the next PR.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@dmjb dmjb requested a review from a team as a code owner June 10, 2024 10:14
Fixes #3555

Implements the new datbase schema. Queries and logic to fill the tables
will be implemented in the next PR.
@JAORMX
Copy link
Contributor

JAORMX commented Jun 10, 2024

Can you add some reasoning about the chosen schema to the PRs description? The design document is not something publicly accessible and transparency is key.

@coveralls
Copy link

Coverage Status

coverage: 53.147% (+0.01%) from 53.137%
when pulling df32c3a on eval-history-schema
into f7fa491 on main.

@dmjb dmjb merged commit 55f84a9 into main Jun 10, 2024
25 checks passed
@dmjb dmjb deleted the eval-history-schema branch June 10, 2024 10:34
@coveralls
Copy link

Coverage Status

coverage: 53.137%. remained the same
when pulling df32c3a on eval-history-schema
into f7fa491 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new evaluation history table structures
3 participants