Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint errors from #2798 #3586

Closed
wants to merge 1 commit into from

Conversation

evankanderson
Copy link
Member

Summary

Fixes lint errors that didn't show up through the GHSA process (which can't run tests)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Ran unit tests

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@evankanderson evankanderson requested a review from a team as a code owner June 12, 2024 15:54
@rdimitrov
Copy link
Member

It needs another make lint-fix

@coveralls
Copy link

Coverage Status

coverage: 53.23%. remained the same
when pulling a7f2cec on evankanderson:fix-lint
into 9cba1f3 on stacklok:main.

@evankanderson
Copy link
Member Author

Preferring #3587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants