Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover from panics in policy engine #3597

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Recover from panics in policy engine #3597

merged 1 commit into from
Jun 13, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Jun 13, 2024

Summary

Currently, if there's a panic caused by the evaluation of a policy or
execution of an action, Minder panics and restarts. This is not ideal.
We instead explicitly recover from panics and surface the error up to
the user.

A user will only see that there was an internal error in Minder, but a
relevant log entry will be written.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Currently, if there's a panic caused by the evaluation of a policy or
execution of an action, Minder panics and restarts. This is not ideal.
We instead explicitly recover from panics and surface the error up to
the user.

A user will only see that there was an internal error in Minder, but a
relevant log entry will be written.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
@JAORMX JAORMX requested a review from a team as a code owner June 13, 2024 12:38
@coveralls
Copy link

Coverage Status

coverage: 53.345% (-0.02%) from 53.36%
when pulling 40d07cb on recover-engine
into 4907092 on main.

@JAORMX JAORMX merged commit d02d1b8 into main Jun 13, 2024
22 checks passed
@JAORMX JAORMX deleted the recover-engine branch June 13, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants