Do not dereference go dependency fields without checking the length of fields first #3598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f fields first Or else malformed patches might cause us trouble.
JAORMX
approved these changes
Jun 13, 2024
dmjb
approved these changes
Jun 13, 2024
Comment on lines
+195
to
+197
| if len(fields) < 5 { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Does this duplicate the condition on the line above (&& len(fields) >= 5)?
There was a problem hiding this comment.
oops you're right. I fixed the condition for the require path and then didn't see the && len part and ended up just adding a redundant check. I'll send a follow-up. Thanks for noticing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Or else malformed patches might cause us trouble.
Change Type
Testing
added a test
Review Checklist: