Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an InviteService #3628

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Create an InviteService #3628

merged 2 commits into from
Jun 14, 2024

Conversation

rdimitrov
Copy link
Member

Summary

The following PR creates an InviteService for verifying and fetching invite metadata

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@rdimitrov rdimitrov requested a review from a team as a code owner June 14, 2024 10:34
@coveralls
Copy link

Coverage Status

coverage: 53.453% (-0.001%) from 53.454%
when pulling 667c018 on invite-service
into 266f0f4 on main.

@JAORMX
Copy link
Contributor

JAORMX commented Jun 14, 2024

@rdimitrov remember that new services need to be added to the ingress configuration in the helm chart.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@coveralls
Copy link

Coverage Status

coverage: 53.435% (-0.02%) from 53.456%
when pulling 041188f on invite-service
into 457f6ab on main.


message GetInviteDetailsResponse {
// Project associated with the invite
string project_display = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this only the project's display name? don't we want to show the actual project's name or ID?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Display name is enough in this case since this API will be used solely to query invite metadata based on the invite code so the FE can fill things like "X invited you to join Y"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we'd be persisting the project elsewhere, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes 👍

@rdimitrov rdimitrov merged commit cd5d5b4 into main Jun 14, 2024
22 checks passed
@rdimitrov rdimitrov deleted the invite-service branch June 14, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants