Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add display name for permission roles and use it in ListRoles #3629

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

rdimitrov
Copy link
Member

Summary

The following PR:

  • Extends the ListRoles response to include the role display name
  • Adds a map of openfga roles to their display names
  • Update the description for each role

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov requested a review from a team as a code owner June 14, 2024 12:52
@coveralls
Copy link

Coverage Status

coverage: 53.461% (+0.007%) from 53.454%
when pulling b50b39f on role-display-name
into b351409 on main.

@rdimitrov rdimitrov merged commit 457f6ab into main Jun 14, 2024
23 checks passed
@rdimitrov rdimitrov deleted the role-display-name branch June 14, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants