Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set evaluation errpr immediately after evaluation #3635

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jun 17, 2024

This got moved during refactoring and it needs to be set before the actions take place.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This got moved during refactoring and it needs to be set before the
actions take place.
@dmjb dmjb requested a review from a team as a code owner June 17, 2024 08:22
@dmjb dmjb changed the title Log eval error after evaluation Set evaluation errpr immediately after evaluation Jun 17, 2024
@coveralls
Copy link

Coverage Status

coverage: 53.39% (-0.02%) from 53.405%
when pulling b38bc6a on fix-eval-err
into 81fe44f on main.

@rdimitrov rdimitrov merged commit d353230 into main Jun 17, 2024
24 of 25 checks passed
@rdimitrov rdimitrov deleted the fix-eval-err branch June 17, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants