Various changes to the eval history schema service #3637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blkt
previously approved these changes
Jun 17, 2024
JAORMX
reviewed
Jun 18, 2024
|
|
||
| -- use an array of timestamps instead of a separate table when tracking evaluation instances | ||
| DROP TABLE IF EXISTS evaluation_instance; | ||
| ALTER TABLE evaluation_statuses ADD COLUMN evaluation_times TIMESTAMP[] NOT NULL DEFAULT ARRAY[]::TIMESTAMP[]; |
There was a problem hiding this comment.
upon writing a row on this table, wouldn't we want there to be one evaluation by default? That is, an array with one item which is NOW()? Or, do we pre-populate this table and only add an evaluation time afterwards?
dmjb
force-pushed
the
eval-history-changes
branch
from
ea965e8
to
e57586c
Compare
These relate to feedback from the design review, plus making some changes in light of writing code which uses these tables: 1) Use `ON DELETE CASCADE` for all foreign key references. 2) Use an array of timestamps to store the evaluation instances instead of keeping them in a separate table. 3) Change some of the table names. The original names were not particular consistent or intuitive. Since Minder does not use any of these tables at this point, there should be no impact from these changes.
dmjb
force-pushed
the
eval-history-changes
branch
from
e57586c
to
634676f
Compare
JAORMX
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These relate to feedback from the design review, plus making some changes in light of writing code which uses these tables:
ON DELETE CASCADEfor all foreign key references.of keeping them in a separate table.
particularly consistent or intuitive.
Since Minder does not use any of these tables at this point, there should be no impact from these changes.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: