Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nil values from Trusty API #3638

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

eleftherias
Copy link
Contributor

Summary

Handle possible nil values in the activity and provenance scores returned by the Trusty API.
The Trusty team made a change today that allowed nil values in the response, while previously they would alway return a float.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner June 17, 2024 16:18
@coveralls
Copy link

Coverage Status

coverage: 53.395% (-0.01%) from 53.405%
when pulling 8313245 on eleftherias:trusty-nil-score
into d353230 on stacklok:main.

@eleftherias eleftherias merged commit 6a4341b into mindersec:main Jun 17, 2024
22 checks passed
@eleftherias eleftherias deleted the trusty-nil-score branch June 17, 2024 16:29
dmjb pushed a commit that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants