Fall back to $XDG_CONFIG_PATH/minder/config.yaml when reading configuration
#3645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blkt
reviewed
Jun 18, 2024
…guration This allows us to have a predictable configuration file when reading the client minder configuration. The idea is that we could set up `$XDG_CONFIG_PATH/minder/config.yaml` and that would serve as an entrypoint. In the future, we could modify this if we want to dynamically change the current working project. Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
JAORMX
changed the title
$HOME/.minder.yaml when reading configuration$XDG_CONFIG_PATH/minder/config.yaml when reading configuration
rdimitrov
reviewed
Jun 18, 2024
| @@ -73,7 +74,7 @@ Configuration options include: | |||
| - identity.cli.issuer_url | |||
| - identity.cli.client_id | |||
|
|
|||
| By default, we look for the file as $PWD/config.yaml. You can specify a custom path via the --config flag, or by setting the MINDER_CONFIG environment variable.`, | |||
| By default, we look for the file as $PWD/config.yaml and $XDG_CONFIG_PATH/minder/config.yaml. You can specify a custom path via the --config flag, or by setting the MINDER_CONFIG environment variable.`, | |||
There was a problem hiding this comment.
How does this work if both are present? Is it that one gets a preference over the other or it's something else?
There was a problem hiding this comment.
one gets preference. First $PWD/config.yaml, then the other one.
There was a problem hiding this comment.
Got it, I was afraid we can accidentally get in a state of conflict if there are two config files present 👍
rdimitrov
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows us to have a predictable configuration file when reading the
client minder configuration. The idea is that we could set up
$XDG_CONFIG_PATH/minder/config.yamland that would serve as an entrypoint.In the future, we could modify this if we want to dynamically change
the current working project.
Change Type
Mark the type of change your PR introduces:
Testing
Review Checklist: