Define API structures for evaluation history #3647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blkt
force-pushed
the
history-proto-defs
branch
2 times, most recently
from
6a89b3f
to
33be5ea
Compare
blkt
reviewed
Jun 26, 2024
This contains the message body definitions as protobufs for the evaluation history endpoints. The endpoints themselves are not defined yet since we want to figure out how pagination will work.
As part of this development, a Cursor message was added to implement pagination.
jhrozek
reviewed
Jun 27, 2024
| EvaluationHistoryRemediation remediation = 5; | ||
| } | ||
|
|
||
| message EvaluationHistoryEntity { |
There was a problem hiding this comment.
Since these messages are only used inside EvaluationHistory, have you considered defining them there? (You could still access them outside with a qualified name, see https://protobuf.dev/programming-guides/proto3/#nested)
There was a problem hiding this comment.
I like the idea but don't fully grasp all implications.
Those messages are not yet used in the application, I would move them in a separate PR.
jhrozek
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This contains the message body definitions as protobufs for the evaluation history endpoints. The endpoint is just a stub enabled via feature flag.
Fixes #3558
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: