Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name validation for projects #3658

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Add name validation for projects #3658

merged 1 commit into from
Jun 19, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Jun 19, 2024

Summary

This allows for simple alphanumeric and DNS names to be considered valid
for projects. The intention is to be able to use / in the future as a
separator to traverse project hierarchies and to simplify project naming
conventions.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@JAORMX JAORMX requested a review from a team as a code owner June 19, 2024 08:36
@JAORMX JAORMX marked this pull request as draft June 19, 2024 08:36
@JAORMX
Copy link
Contributor Author

JAORMX commented Jun 19, 2024

@rdimitrov note that this is ready, however, I've marked it as draft to avoid merging this. This will break the smoke tests as we create some projects with / as separators. Let's fix that first before merging.

@coveralls
Copy link

Coverage Status

coverage: 53.287% (-0.03%) from 53.318%
when pulling c6466c4 on project-name-valid
into 7541461 on main.

@coveralls
Copy link

Coverage Status

coverage: 53.292% (-0.03%) from 53.318%
when pulling c6466c4 on project-name-valid
into 7541461 on main.

@JAORMX JAORMX marked this pull request as ready for review June 19, 2024 09:27
This allows for simple alphanumeric and DNS names to be considered valid
for projects. The intention is to be able to use `/` in the future as a
separator to traverse project hierarchies and to simplify project naming
conventions.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
@JAORMX JAORMX requested review from jhrozek, eleftherias and aponcedeleonch and removed request for aponcedeleonch June 19, 2024 09:54
@JAORMX JAORMX merged commit bd376ce into main Jun 19, 2024
21 checks passed
@JAORMX JAORMX deleted the project-name-valid branch June 19, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants