Add email and is_accepted to invitation-related proto messages #3665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
rdimitrov
commented
Jun 19, 2024
| @@ -929,7 +929,7 @@ service InviteService { | |||
| }; | |||
|
|
|||
| option (rpc_options) = { | |||
| target_resource: TARGET_RESOURCE_PROJECT | |||
| target_resource: TARGET_RESOURCE_NONE | |||
There was a problem hiding this comment.
This is needed so we can make the method explicitly available to unauthenticated users.
dmjb
approved these changes
Jun 19, 2024
|
Changes unknown |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The following PR adds email and is_accepted to invitation-related proto messages
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: