Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GetInviteDetails #3668

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Implement GetInviteDetails #3668

merged 1 commit into from
Jun 19, 2024

Conversation

rdimitrov
Copy link
Member

Summary

The following PR implements the GetInviteDetails API for getting additional metadata info for invite codes. This is intended to be a public API accessed by unauthenticated users.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov requested a review from a team as a code owner June 19, 2024 16:05
@dmjb
Copy link
Contributor

dmjb commented Jun 19, 2024

This could probably benefit from unit test coverage as well, although not as much as the other PR.

@coveralls
Copy link

Coverage Status

coverage: 53.394% (-0.08%) from 53.476%
when pulling dffd69c on invite-service
into 07f93e0 on main.

@rdimitrov
Copy link
Member Author

This could probably benefit from unit test coverage as well, although not as much as the other PR.

Created #3670

@rdimitrov rdimitrov merged commit cfeaed8 into main Jun 19, 2024
22 checks passed
@rdimitrov rdimitrov deleted the invite-service branch June 19, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants