Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper functions for checking/setting invite expiration #3698

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Conversation

rdimitrov
Copy link
Member

Summary

The following PR adds helper functions for checking/setting invite expiration. Also sets the const scope to local as they are not really meant to be used in other way.

Split from #3689

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov requested a review from a team as a code owner June 24, 2024 09:49
@rdimitrov rdimitrov self-assigned this Jun 24, 2024
@coveralls
Copy link

Coverage Status

coverage: 52.731% (-0.02%) from 52.752%
when pulling 8b4a693 on inv
into 07fc788 on main.

Co-authored-by: Eleftheria Stein-Kousathana <eleftheria@stacklok.com>
@rdimitrov rdimitrov merged commit 5f200ed into main Jun 24, 2024
20 checks passed
@rdimitrov rdimitrov deleted the inv branch June 24, 2024 10:03
@coveralls
Copy link

Coverage Status

coverage: 52.727% (-0.03%) from 52.752%
when pulling 63b2e6b on inv
into 07fc788 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants