Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with multiple entity IDs #3699

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Fix issue with multiple entity IDs #3699

merged 2 commits into from
Jun 24, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jun 24, 2024

Spotted by @eleftherias in smoke tests. When evaluating a PR, the repo ID is also passed around. This violated the assumption that only one entity type would be specified.

Change the logic so that we try and find a PR or artifact ID first, then a repo ID later.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Spotted by @eleftherias in smoke tests. When evaluating a PR, the repo
ID is also passed around. This violated the assumption that only one
entity type would be specified.

Change the logic so that we try and find a PR or artifact ID first, then
a repo ID later.
@dmjb dmjb requested a review from a team as a code owner June 24, 2024 11:07
@coveralls
Copy link

Coverage Status

coverage: 52.746% (+0.02%) from 52.727%
when pulling 3bfda5c on fix-multi-id-issue
into 5f200ed on main.

@coveralls
Copy link

Coverage Status

coverage: 52.736% (+0.009%) from 52.727%
when pulling 3bfda5c on fix-multi-id-issue
into 5f200ed on main.

@dmjb dmjb merged commit ef45f63 into main Jun 24, 2024
21 checks passed
@dmjb dmjb deleted the fix-multi-id-issue branch June 24, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants