Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EngineContext outside of the engine package #3701

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jun 24, 2024

This avoids a circular dependency when importing the flags package into engine

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@dmjb dmjb requested a review from a team as a code owner June 24, 2024 13:52
@dmjb dmjb force-pushed the move-enginecontext-struct branch 2 times, most recently from 2393141 to ab5b0c0 Compare June 24, 2024 13:59
@coveralls
Copy link

Coverage Status

coverage: 52.741% (+0.005%) from 52.736%
when pulling 2393141 on move-enginecontext-struct
into ef45f63 on main.

@dmjb dmjb force-pushed the move-enginecontext-struct branch 3 times, most recently from 7a0fa37 to c4ab281 Compare June 24, 2024 14:04
This avoids a circular dependency when importing the `flags` package
into `engine`
@dmjb dmjb force-pushed the move-enginecontext-struct branch from c4ab281 to bac65f3 Compare June 24, 2024 14:05
@coveralls
Copy link

Coverage Status

coverage: 52.741% (+0.005%) from 52.736%
when pulling bac65f3 on move-enginecontext-struct
into ef45f63 on main.

@coveralls
Copy link

Coverage Status

coverage: 52.736%. remained the same
when pulling bac65f3 on move-enginecontext-struct
into ef45f63 on main.

@coveralls
Copy link

Coverage Status

coverage: 52.736%. remained the same
when pulling bac65f3 on move-enginecontext-struct
into ef45f63 on main.

@coveralls
Copy link

Coverage Status

coverage: 52.736%. remained the same
when pulling bac65f3 on move-enginecontext-struct
into ef45f63 on main.

@coveralls
Copy link

Coverage Status

coverage: 52.736%. remained the same
when pulling bac65f3 on move-enginecontext-struct
into ef45f63 on main.

@dmjb dmjb merged commit b5398b9 into main Jun 24, 2024
21 checks passed
@dmjb dmjb deleted the move-enginecontext-struct branch June 24, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants