Start using new eval history table #3703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evankanderson
approved these changes
Jun 24, 2024
evankanderson
previously approved these changes
Jun 24, 2024
There was a problem hiding this comment.
This cleanup is not directly related to the rest of the PR, right? (It's okay, just trying to make sure I understand.)
There was a problem hiding this comment.
I realized when I wired these metrics into the engine that I was using the wrong type for status.
dmjb
force-pushed
the
wire-up-history-logs
branch
3 times, most recently
from
eaf5228
to
6268bde
Compare
This PR wires the eval history service into the evaluation engine. It is gated behind a feature flag while we experiment with it. A follow on PR will add logging for remediation and alerting. Relates to #3556
dmjb
force-pushed
the
wire-up-history-logs
branch
from
7de1c11
to
cd843e8
Compare
dmjb
force-pushed
the
wire-up-history-logs
branch
from
cd843e8
to
b6d11cb
Compare
rdimitrov
approved these changes
Jun 26, 2024
Comment on lines
-153
to
+166
| RuleEvalID: id, | ||
| RuleEvalID: evalID, |
There was a problem hiding this comment.
I suppose it's intended but why did we switched from one to another?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wires the eval history service into the evaluation engine. It is gated behind a feature flag while we experiment with it. A follow on PR will add logging for remediation and alerting.
Relates to #3556
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: