Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not return the invite code when listing role assignments and set display name defaults #3710

Merged
merged 6 commits into from
Jun 25, 2024

Conversation

rdimitrov
Copy link
Member

@rdimitrov rdimitrov commented Jun 25, 2024

Summary

The following PR addresses the feedback from #3689.

There'll be a follow up with some of the other items from that list.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov requested a review from a team as a code owner June 25, 2024 09:08
@rdimitrov rdimitrov self-assigned this Jun 25, 2024
@rdimitrov rdimitrov marked this pull request as draft June 25, 2024 09:09
@coveralls
Copy link

Coverage Status

coverage: 52.432%. remained the same
when pulling 59bdfd9 on feedback
into 98373ad on main.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@coveralls
Copy link

Coverage Status

coverage: 52.441% (+0.009%) from 52.432%
when pulling 51f143d on feedback
into 98373ad on main.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@coveralls
Copy link

Coverage Status

coverage: 52.422% (-0.01%) from 52.432%
when pulling 84a6920 on feedback
into 98373ad on main.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@coveralls
Copy link

Coverage Status

coverage: 52.424% (-0.008%) from 52.432%
when pulling 0ea4ac5 on feedback
into 98373ad on main.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@coveralls
Copy link

Coverage Status

coverage: 52.417% (-0.02%) from 52.432%
when pulling 742bab7 on feedback
into 98373ad on main.

@coveralls
Copy link

Coverage Status

coverage: 52.421% (-0.01%) from 52.432%
when pulling 84e4e7b on feedback
into 98373ad on main.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@coveralls
Copy link

Coverage Status

coverage: 52.412% (-0.02%) from 52.432%
when pulling cef1030 on feedback
into 98373ad on main.

@rdimitrov rdimitrov changed the title Do not return the invite code when listing role assignments Do not return the invite code when listing role assignments and set display name defaults Jun 25, 2024
@rdimitrov rdimitrov marked this pull request as ready for review June 25, 2024 15:07
@rdimitrov rdimitrov merged commit 53fe30a into main Jun 25, 2024
23 checks passed
@rdimitrov rdimitrov deleted the feedback branch June 25, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants