Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow removing the last admin role of a project #3715

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

rdimitrov
Copy link
Member

Summary

The following PR adds a check in case the user is removing the last admin role of a project.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov requested a review from a team as a code owner June 26, 2024 08:31
@coveralls
Copy link

Coverage Status

coverage: 52.49% (+0.02%) from 52.466%
when pulling 3b055ca on remove-admin-check
into cae4b26 on main.

blkt
blkt previously approved these changes Jun 26, 2024
internal/controlplane/handlers_authz.go Outdated Show resolved Hide resolved
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@coveralls
Copy link

Coverage Status

coverage: 52.481% (+0.02%) from 52.466%
when pulling 8f4dee0 on remove-admin-check
into cae4b26 on main.

@rdimitrov rdimitrov merged commit ec370b2 into main Jun 26, 2024
21 checks passed
@rdimitrov rdimitrov deleted the remove-admin-check branch June 26, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants