Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse the previous invite code when updating an invitation #3719

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

rdimitrov
Copy link
Member

@rdimitrov rdimitrov commented Jun 26, 2024

Summary

The following PR reuses the previous invite code when updating an invitation. This would allow for older invitations to still work. The initial email content may not reflect the new state, but we are okay with this (synced with Evan) there'll be a follow up email being send in case the role changed

  • Waiting for confirmation from @ethomson in case we don't want this behavior.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov requested a review from a team as a code owner June 26, 2024 11:18
@rdimitrov rdimitrov self-assigned this Jun 26, 2024
@coveralls
Copy link

Coverage Status

coverage: 52.53% (+0.03%) from 52.5%
when pulling 89935e6 on reuse-code
into 6cc166f on main.

@coveralls
Copy link

Coverage Status

coverage: 52.473% (+0.04%) from 52.438%
when pulling d898137 on reuse-code
into 37323cd on main.

@ethomson
Copy link
Member

The initial email content may not reflect the new state

Okay, so -- what happens is:

  • admin invites user with role x
  • user gets email telling them that they were invited with role x, and an invite link
  • admin updates user's role to y
  • user gets another email telling them that that they were invited with role y, and (the same) invite link

I think that's great, :shipit:

@rdimitrov rdimitrov merged commit 1b8a332 into main Jun 26, 2024
21 checks passed
@rdimitrov rdimitrov deleted the reuse-code branch June 26, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants