Split message handling logic out of Executor #3730
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the interface of the Executor directly consumes messages from a message queue, and then publishes a message to another queue once the evaluation is complete. This leads to some issues with testing:
publishing. If the tests fail while running
make test
, the testhangs until the timeout happens.
message and telemetry code, meaning that it's hard to figure out why
exactly a test has failed.
This PR splits the Executor into two: the ExecutorEventHandler which handles all interactions with message queues, and the Executor which contains the logic for entity evaluation minus event handling.
The intention is that the tests for ExecutorEventHandler can use a mock of the Executor. Since the message handling logic is unlikely to change often, this should reduce the situations where the async tests fail and we end up with long hangs in the test. This test cleanup work will be implemented in a separate PR.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: