Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm run serve example in the docs' README #3734

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Jun 27, 2024

Summary

The previous example npm run serve -p 3001 was giving me errors.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

follow the steps in the readme

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

The previous example `npm run serve -p 3001` was giving me errors.
@jhrozek jhrozek requested a review from a team as a code owner June 27, 2024 13:15
@coveralls
Copy link

Coverage Status

coverage: 52.473% (-0.009%) from 52.482%
when pulling c186ac7 on jhrozek:misc
into fe18235 on stacklok:main.

@rdimitrov rdimitrov merged commit 28b8ece into mindersec:main Jun 27, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants