Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates #3738

Merged
merged 16 commits into from
Jun 28, 2024
Merged

Documentation updates #3738

merged 16 commits into from
Jun 28, 2024

Conversation

ethomson
Copy link
Member

@ethomson ethomson commented Jun 28, 2024

Summary

Several documentation updates, primarily around the Getting Started content.

  • Move Getting Started up in the left-hand sidebar navigation menu; since getting started is the first thing that someone does, it remains on top (even above the conceptual, "learn Minder" content). This allows people to try Minder first, then dig deeper into understanding.
  • Update some of the getting started documentation to be a little more clear, and more of a consistent "learning path" through the experience
  • Switch to Sentence case consistently (at least within the left-hand sidebar navigation)
  • Use gerund form consistently (again, at least within the left-hand sidebar navigation)
  • Collapse the two "add a user" docs (I think one was leftover from a previous refactor?)
  • Move the CLI configuration out of getting started

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Clicked through; read; ensured no dead links. 🤞

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Explain what the Minder CLI can talk to; remove discussion about running
/ installing the server and link to the separate running / installing
the server page.
When we say "here" as a link target, it becomes subtly hard to read.
Expand the URL in order to promote visibility.
* Explain the default is to Minder Cloud
* Clarify that we're enrolling the GitHub provider; we'll have other
  providers in the future, but we can be more clear about the current
  state.
* Clarify that you don't need to enroll if you did a quickstart.
* For prerequisites, don't list all the prerequisites; they implicitly
  chain, so you only need to point to the previous step in the getting
  started guide.
The status viewing documentation deserves its own page, outside of the
profile creation page.
There's a lot of details in the repository registration page that aren't
strictly applicable to getting started. Move them out into their own
page so that the getting started page remains simpler.
The CLI configuration is a non-trivial bit; move it into the reference
section.
@ethomson ethomson requested a review from a team as a code owner June 28, 2024 11:01
@coveralls
Copy link

Coverage Status

coverage: 52.443% (+0.004%) from 52.439%
when pulling b697a80 on ethomson/docs
into 674252b on main.

@coveralls
Copy link

Coverage Status

coverage: 52.434% (-0.005%) from 52.439%
when pulling 9b89632 on ethomson/docs
into 674252b on main.

Copy link
Contributor

@blkt blkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks for the huge work!

You can also register an individual repository by name, or a set of repositories, comma-separated. For example:

```bash
minder repo register --name "owner/repo1,owner/repo2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: IIRC we also support repeated --name flags, e.g.

$ minder repo register --name owner/repo1 --name owner/repo2

* [A Minder account](./login.md)
* [An enrolled GitHub token](./login.md#enrolling-the-github-provider) that is either an Owner in the organization or an Admin on the repositories
* [One or more repositories registered with Minder](./register_repos.md)
Before you can create a profile, you should [register repositories](register_repos).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this is not strictly a prerequisite, but I guess this is the desired experience for a user going through the docs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. 😁 I worded it as should because of that. I didn't really want to untangle all the details in the getting started page. 😁

@ethomson ethomson merged commit 7b32039 into main Jun 28, 2024
19 checks passed
@ethomson ethomson deleted the ethomson/docs branch June 28, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants