-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation updates #3738
Documentation updates #3738
Conversation
Explain what the Minder CLI can talk to; remove discussion about running / installing the server and link to the separate running / installing the server page.
When we say "here" as a link target, it becomes subtly hard to read. Expand the URL in order to promote visibility.
* Explain the default is to Minder Cloud * Clarify that we're enrolling the GitHub provider; we'll have other providers in the future, but we can be more clear about the current state. * Clarify that you don't need to enroll if you did a quickstart. * For prerequisites, don't list all the prerequisites; they implicitly chain, so you only need to point to the previous step in the getting started guide.
The status viewing documentation deserves its own page, outside of the profile creation page.
There's a lot of details in the repository registration page that aren't strictly applicable to getting started. Move them out into their own page so that the getting started page remains simpler.
The CLI configuration is a non-trivial bit; move it into the reference section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and thanks for the huge work!
You can also register an individual repository by name, or a set of repositories, comma-separated. For example: | ||
|
||
```bash | ||
minder repo register --name "owner/repo1,owner/repo2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: IIRC we also support repeated --name
flags, e.g.
$ minder repo register --name owner/repo1 --name owner/repo2
* [A Minder account](./login.md) | ||
* [An enrolled GitHub token](./login.md#enrolling-the-github-provider) that is either an Owner in the organization or an Admin on the repositories | ||
* [One or more repositories registered with Minder](./register_repos.md) | ||
Before you can create a profile, you should [register repositories](register_repos). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this is not strictly a prerequisite, but I guess this is the desired experience for a user going through the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. 😁 I worded it as should because of that. I didn't really want to untangle all the details in the getting started page. 😁
Summary
Several documentation updates, primarily around the Getting Started content.
Change Type
Mark the type of change your PR introduces:
Testing
Clicked through; read; ensured no dead links. 🤞
Review Checklist: