Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate event handler and executor unit tests #3740

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jun 28, 2024

This follows on from the previous PR: simplify the event handler tests to the minimum. This means that the event handling tests (which have asynchronous behaviour and may time out) will not fail when changes are made to the executor logic.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This follows on from the previous PR: simplify the event handler tests
to the minimum. This means that the event handling tests (which have
asynchronous behaviour and may time out) will not fail when changes are
made to the executor logic.
@dmjb dmjb requested a review from a team as a code owner June 28, 2024 15:10
internal/engine/handler.go Outdated Show resolved Hide resolved
rdimitrov
rdimitrov previously approved these changes Jun 28, 2024
@rdimitrov rdimitrov dismissed their stale review June 28, 2024 15:18

Dismissing based on the comment from Puerco. Missed it!

@coveralls
Copy link

Coverage Status

coverage: 52.436% (-0.003%) from 52.439%
when pulling acb7c3f on refactor-handler-unit-test
into 674252b on main.

Copy link
Contributor

@puerco puerco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coveralls
Copy link

Coverage Status

coverage: 52.434% (-0.005%) from 52.439%
when pulling 316acca on refactor-handler-unit-test
into 674252b on main.

@dmjb dmjb merged commit 83ae180 into main Jun 28, 2024
21 checks passed
@dmjb dmjb deleted the refactor-handler-unit-test branch June 28, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants