Cache RuleTypeEngine instances in Executor #3741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmjb
force-pushed
the
rule-engine-cache
branch
6 times, most recently
from
744d070
to
e1a9e0e
Compare
This simplifies an upcoming PR, and also addresses a comment in the code about avoiding continuously re-querying for rule types. This PR changes the executor to load all relevant rule types before evaluation and construct RuleTypeEngine instances for each. These are then stored in a cache and used during rule evaluation. Certain aspects of this change (specifically, the need to query for the rule type ID) are a bit clunky, but will be simplified in an upcoming PR.
JAORMX
reviewed
Jul 15, 2024
JAORMX
reviewed
Jul 15, 2024
dmjb
commented
Jul 15, 2024
| @@ -131,7 +131,6 @@ type EvalStatusParams struct { | |||
| Result *Result | |||
| Profile *pb.Profile | |||
| Rule *pb.Profile_Rule | |||
| RuleTypeName string | |||
There was a problem hiding this comment.
Populating the eval params struct with the rule type name was awkward with in the new codepath for loading rule types, and it was only used in one place for evaluation telemetry. I decided instead to pass the rule type name via a different mechanism to the telemetry code.
JAORMX
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies an upcoming PR, and also addresses a comment in the code about the need to cache rule type lookups. This PR changes the executor to load all relevant rule types before evaluation, and construct RuleTypeEngine instances for each. The RuleTypeEngine instances are stored in a cache and reused during rule evaluation, instead of the current approach which constructs a new RuleTypeEngine for each rule instance which is evaluated.
Certain aspects of this change (specifically, the need to query for the rule type ID) are a bit clunky, but will be simplified in an upcoming PR.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: