Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ProjectRoles field to GetUserResponse #3755

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Add ProjectRoles field to GetUserResponse #3755

merged 3 commits into from
Jul 2, 2024

Conversation

rdimitrov
Copy link
Member

Summary

The following PR adds a new field to the GetUserResponse which includes a list of {role, project). This was needed because there was no easy way for a user to get their role assignments in all of their projects.

The PR includes the necessary changes on the CLI side.

Also the existing field is left there but will be deprecated ones all clients migrate to the new one.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov requested a review from a team as a code owner July 2, 2024 09:33
@rdimitrov rdimitrov self-assigned this Jul 2, 2024
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov merged commit 9ab8122 into main Jul 2, 2024
22 checks passed
@rdimitrov rdimitrov deleted the projectroles branch July 2, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants