Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to fill roles if project has none #3761

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Do not try to fill roles if project has none #3761

merged 1 commit into from
Jul 2, 2024

Conversation

rdimitrov
Copy link
Member

Summary

The following PR fixes and issue with sub-projects. Apparently when we create one we don't create role assignments for this sub-projects in openfga. This caused the backend to return an error when trying to build the user's project list info during GetUser.

This is a temporary fix, but perhaps the right way to fix it is to update the project create part and populate it with the right assignments

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov requested a review from a team as a code owner July 2, 2024 13:54
@rdimitrov rdimitrov self-assigned this Jul 2, 2024
@coveralls
Copy link

Coverage Status

coverage: 51.927% (+0.007%) from 51.92%
when pulling 22e1e74 on fix-role
into 35d9eb4 on main.

@rdimitrov rdimitrov merged commit 4cad6c7 into main Jul 2, 2024
22 checks passed
@rdimitrov rdimitrov deleted the fix-role branch July 2, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants