Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate jwt functionality into its own package #3770

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

eleftherias
Copy link
Contributor

Summary

This moves any JWT specific auth code into its own package.
There are not functional changes.
This is intended to make the code more testable.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner July 3, 2024 10:19
@coveralls
Copy link

Coverage Status

coverage: 51.893% (+0.009%) from 51.884%
when pulling 35f7263 on eleftherias:jwt-separate-package
into 5106a3c on stacklok:main.

@coveralls
Copy link

Coverage Status

coverage: 51.893% (+0.009%) from 51.884%
when pulling 1f8e1ee on eleftherias:jwt-separate-package
into 5106a3c on stacklok:main.

@eleftherias eleftherias merged commit a75c435 into mindersec:main Jul 3, 2024
21 checks passed
@eleftherias eleftherias deleted the jwt-separate-package branch July 3, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants