Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invite email: color and padding changes #3771

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Invite email: color and padding changes #3771

merged 2 commits into from
Jul 3, 2024

Conversation

ethomson
Copy link
Member

@ethomson ethomson commented Jul 3, 2024

Summary

Tweak the padding and background color for the email template.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Manual email send

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@ethomson ethomson requested a review from a team as a code owner July 3, 2024 10:44
@ethomson
Copy link
Member Author

ethomson commented Jul 3, 2024

There's a couple of other things that I'd like to change that I didn't here.

  • The verbiage should be "become an editor" or "become a member", not "become editor" or "become member". I don't know the best way to effect this - maybe the templating language has conditionals but I didn't want to mess around here.
  • The text of the text email. I think it might make more sense to pull that into a template, too, but that's a bit beyond my capabilities.

@coveralls
Copy link

Coverage Status

coverage: 51.884%. remained the same
when pulling b107213 on ethomson/email
into 5106a3c on main.

@coveralls
Copy link

Coverage Status

coverage: 51.884%. remained the same
when pulling b107213 on ethomson/email
into 5106a3c on main.

@rdimitrov rdimitrov merged commit f9bd74d into main Jul 3, 2024
21 checks passed
@rdimitrov rdimitrov deleted the ethomson/email branch July 3, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants