Show the subject display name along with the ID in minder role #3772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleftherias
reviewed
Jul 3, 2024
| @@ -81,7 +81,7 @@ func GrantListCommand(ctx context.Context, cmd *cobra.Command, _ []string, conn | |||
| case app.Table: | |||
| t := initializeTableForGrantListRoleAssignments() | |||
| for _, r := range resp.RoleAssignments { | |||
| t.AddRow(r.Subject, r.Role, *r.Project) | |||
| t.AddRow(fmt.Sprintf("%s / %s", r.DisplayName, r.Subject), r.Role, *r.Project) | |||
There was a problem hiding this comment.
Do you think it's worth adding another column to the table, because the current column title is "Subject" and with this change it will contain both the subject and the display name.
There was a problem hiding this comment.
I did do it like that initially, but it stretched the table too much, so I thought to reuse what we do in the auth command (where projects are displayed in a similar pattern - project_name / project_id). I can make it in the other way if you think it would be better 👍
There was a problem hiding this comment.
Maybe we include both in the same column, but change the title from "Subject" to "User"?
There was a problem hiding this comment.
Sounds good 👍 I'll push a commit 👍
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
rdimitrov
force-pushed
the
subject-display-name
branch
from
401f927
to
5ec224f
Compare
eleftherias
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The following PR includes the subject display name when listing or updating role assignments. Previously it was just the ID.
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: