Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for GetInviteDetails #3773

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Add unit test for GetInviteDetails #3773

merged 1 commit into from
Jul 4, 2024

Conversation

eleftherias
Copy link
Contributor

Summary

Adds a test for GetInviteDetails. Also, generates new mocks needed for the test.

Fix #3670

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner July 3, 2024 12:41
@coveralls
Copy link

Coverage Status

coverage: 52.011% (+0.1%) from 51.888%
when pulling 421c8f3 on eleftherias:3670-get-invite-details-test
into a75c435 on stacklok:main.

@eleftherias eleftherias force-pushed the 3670-get-invite-details-test branch from 421c8f3 to 966cd88 Compare July 4, 2024 07:39
@coveralls
Copy link

Coverage Status

coverage: 52.011% (+0.1%) from 51.893%
when pulling 966cd88 on eleftherias:3670-get-invite-details-test
into aa4e567 on stacklok:main.

@eleftherias eleftherias merged commit ff2be84 into mindersec:main Jul 4, 2024
20 checks passed
@eleftherias eleftherias deleted the 3670-get-invite-details-test branch July 4, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdimitrov rdimitrov rdimitrov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit test for GetInviteDetails
3 participants
@eleftherias @coveralls @rdimitrov