Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ListEvaluationHistory RPC implementation. #3784

Merged
merged 13 commits into from
Jul 10, 2024
Merged

Added ListEvaluationHistory RPC implementation. #3784

merged 13 commits into from
Jul 10, 2024

Commits on Jul 10, 2024

  1. Added ListEvaluationHistory RPC implementation. 

    ListEvaluationHistory RPC returns a paginated list of evaluation
events based on the given cursor and filter.

Routines for managing a filter are implemented as well, in a way that
should be reusable within other endpoints supporting filters. This
implementation only allows and-joined predicates. Such predicates
allow only or-joined equality/inequality checks. Simply put, if a
filter entry starts with the exclamation mark, it is added to the
inequality check, while it is added to the equality check
otherwise. Finally, timerange based filtering is supported.

Routines for managing a cursor are implemented as well, but are not
intended to be generic. Cursors are tightly coupled with the
underlying extraction logic and are harder to refactor, and the
additional effort was not considered valuable at this time.

Fixes #3746
    @blkt
    blkt committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    e0850b2 View commit details
    Browse the repository at this point in the history

  2. Handler-to-Service wiring.

    @blkt
    blkt committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    bdf55ef View commit details
    Browse the repository at this point in the history

  3. Filter and Cursor routines fully tested.

    @blkt
    blkt committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    ea8bbf3 View commit details
    Browse the repository at this point in the history

  4. Added extraction form database.

    @blkt
    blkt committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    c4e7618 View commit details
    Browse the repository at this point in the history

  5. Added service tests.

    @blkt
    blkt committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    dfbd2d2 View commit details
    Browse the repository at this point in the history

  6. Prevent filtering for both inclusion and exclusion.

    @blkt
    blkt committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    b7b255b View commit details
    Browse the repository at this point in the history

  7. Revert changes to feature flag check. 

    This was necessary for local testing because of the following issue.
#3775
    @blkt
    blkt committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    fd073f2 View commit details
    Browse the repository at this point in the history

  8. Setting query params in a more readable fashion.

    @blkt
    blkt committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    280dd88 View commit details
    Browse the repository at this point in the history

  9. Refactoring cursor parser for better readability.

    @blkt
    blkt committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    dc7e1c9 View commit details
    Browse the repository at this point in the history

  10. Embed proto messages specific to EvaluationHistory.

    @blkt
    blkt committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    f332e1d View commit details
    Browse the repository at this point in the history

  11. Revert "Embed proto messages specific to EvaluationHistory." 

    This reverts commit 572ab4e.
    @blkt
    blkt committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    e5f701d View commit details
    Browse the repository at this point in the history

  12. Added project id as mandatory filter.

    @blkt
    blkt committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    c9b4400 View commit details
    Browse the repository at this point in the history

  13. Minor tweaks to protobuf messages.

    @blkt
    blkt committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    e1c933d View commit details
    Browse the repository at this point in the history