Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the selector message to the protobuf #3785

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Jul 4, 2024

Summary

Extends the Profile message with a nested message describing the
selectors.

Fixes: #3722

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

as part of a larger branch

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@jhrozek jhrozek requested a review from a team as a code owner July 4, 2024 13:39
@coveralls
Copy link

Coverage Status

coverage: 52.016% (+0.01%) from 52.002%
when pulling f31ba9d on jhrozek:selector_protobuf
into ff2be84 on stacklok:main.

rdimitrov
rdimitrov previously approved these changes Jul 4, 2024
Extends the Profile message with a nested message describing the
selectors.

Fixes: mindersec#3722
@rdimitrov rdimitrov merged commit c01ef70 into mindersec:main Jul 4, 2024
21 checks passed
@coveralls
Copy link

Coverage Status

coverage: 51.837% (-0.005%) from 51.842%
when pulling e65c707 on jhrozek:selector_protobuf
into d521faa on stacklok:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend the Profile protobuf message with a Selector embedded message
3 participants