Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase CLI context timeout to 20s #3803

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

eleftherias
Copy link
Contributor

Summary

Users in Spain (and possibly other regions) are experience continuous context timeouts, because requests to the gRPC endpoints on the server are taking longer than 10 seconds.

This increases the timeout, under the assumption that it's better for the CLI to be slow than to error.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner July 8, 2024 14:57
@coveralls
Copy link

Coverage Status

coverage: 52.204%. remained the same
when pulling c75ae6d on eleftherias:increase-context-timeout
into 11c145f on stacklok:main.

@eleftherias eleftherias merged commit 5e1ca12 into mindersec:main Jul 8, 2024
22 checks passed
@eleftherias eleftherias deleted the increase-context-timeout branch July 8, 2024 15:08
@evankanderson
Copy link
Member

It looks like we're creating the context with timeout around the entire runE function (in grpc.GRPCClientWrapRunE), rather than specifically around individual RPC requests. This means that interactive prompts, parsing, etc all get attributed to this timeout, rather than having a timeout specifically around reaching Minder for RPCs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants