Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openfga entity_reconcile to require the admin role #3818

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

rdimitrov
Copy link
Member

Summary

The following PR updates the entity_reconcile resource to require the admin role

Fixes #3794

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov requested a review from a team as a code owner July 9, 2024 14:26
@coveralls
Copy link

Coverage Status

coverage: 52.206% (+0.005%) from 52.201%
when pulling a3119e4 on entity-role
into 35760c7 on main.

@rdimitrov rdimitrov requested a review from jhrozek July 9, 2024 15:10
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if admin for entity_reconcile is the right value or if we should go the other direction and demote list_remote_repos to editor from admin, but we need to start from being consistent - and this direction is the safer one.

@rdimitrov
Copy link
Member Author

I am not sure if admin for entity_reconcile is the right value or if we should go the other direction and demote list_remote_repos to editor from admin, but we need to start from being consistent - and this direction is the safer one.

Thanks, this was my reasoning too 👍

@rdimitrov rdimitrov merged commit f1a6904 into main Jul 9, 2024
22 checks passed
@rdimitrov rdimitrov deleted the entity-role branch July 9, 2024 15:30
dmjb pushed a commit that referenced this pull request Jul 12, 2024
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update openfga to have the same roles for list repositories and reconcile (now it is editor & admin)
3 participants