Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetProfileByProjectAndID includes selectors #3833

Merged
merged 1 commit into from
Jul 10, 2024
Merged

GetProfileByProjectAndID includes selectors #3833

merged 1 commit into from
Jul 10, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Jul 10, 2024

Summary

We'll want to have the selectors in the reply to use in profile
handlers.

Relates: #3723

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

make test

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@jhrozek
GetProfileByProjectAndID includes selectors
b32f248 
We'll want to have the selectors in the reply to use in profile
handlers.

Relates: mindersec#3723
@jhrozek jhrozek requested a review from a team as a code owner July 10, 2024 13:02
@coveralls
Copy link

Coverage Status

coverage: 52.142% (+0.01%) from 52.128%
when pulling b32f248 on jhrozek:selectors_db
into 9fbf426 on stacklok:main.

@jhrozek jhrozek merged commit 881c672 into mindersec:main Jul 10, 2024
22 checks passed
dmjb pushed a commit that referenced this pull request Jul 12, 2024
@jhrozek @dmjb
GetProfileByProjectAndID includes selectors (#3833)
decda4c 
We'll want to have the selectors in the reply to use in profile
handlers.

Relates: #3723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson evankanderson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhrozek @coveralls @evankanderson