Extend the db-to-pb profile code to include selectors #3854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ProfileRow interface is used to abstract DB rows list with or without labels that are subsequently passed to `MergeDatabaseListIntoProfiles`. Let's extend the interface with a method to get selectors so we can use them in `MergeDatabaseListIntoProfiles`. Fixes: mindersec#3723
`MergeDatabaseListIntoProfiles` creates a protobuf representation of a profile from a database list. Extend the function with the profile selectors from the database list. Related: mindersec#3723
This will be used in selector handlers. Related: mindersec#3723
dmjb
approved these changes
Jul 11, 2024
dmjb
pushed a commit
that referenced
this pull request
Jul 12, 2024
* Extend the ProfileRow interface for selectors The ProfileRow interface is used to abstract DB rows list with or without labels that are subsequently passed to `MergeDatabaseListIntoProfiles`. Let's extend the interface with a method to get selectors so we can use them in `MergeDatabaseListIntoProfiles`. Fixes: #3723 * Add selectors to profile in `MergeDatabaseListIntoProfiles` `MergeDatabaseListIntoProfiles` creates a protobuf representation of a profile from a database list. Extend the function with the profile selectors from the database list. Related: #3723 * `MergeDatabaseGetIntoProfiles` includes selectors This will be used in selector handlers. Related: #3723
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extends the
MergeDatabaseGetIntoProfilesandMergeDatabaseListIntoProfilesfunctions to include selectors. These will be useful later when we extend the
profile handlers.
MergeDatabaseListIntoProfilesMergeDatabaseGetIntoProfilesincludes selectorsRelated: #3723
Change Type
Mark the type of change your PR introduces:
Testing
as part of a larger branch. We'll be able to add tests when we extend the Profile service
and extend the handlers.
Review Checklist: