Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort the authz roles in ListRoles response #3857

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Sort the authz roles in ListRoles response #3857

merged 2 commits into from
Jul 11, 2024

Conversation

rdimitrov
Copy link
Member

Summary

The following PR:

  • Sort the authz roles in ListRoles response
  • Renames a few variables to fix linter warnings

Fixes #3855

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov requested a review from a team as a code owner July 11, 2024 08:08
@coveralls
Copy link

Coverage Status

coverage: 53.077% (-0.02%) from 53.096%
when pulling a68babf on sort-roles
into 9a2ccaa on main.

Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why do the roles need to be sorted?

@rdimitrov
Copy link
Member Author

Out of curiosity, why do the roles need to be sorted?

I should have mentioned this, but the sole reason was a request from FE that it makes it easier for clients to show the available roles based on the level of permissions each role has, i.e. admin is more permissive than editor.

@rdimitrov rdimitrov merged commit a5b4d9b into main Jul 11, 2024
22 checks passed
@rdimitrov rdimitrov deleted the sort-roles branch July 11, 2024 08:44
dmjb pushed a commit that referenced this pull request Jul 12, 2024
* Sort the authz roles in ListRoles response

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>

* Rename AllRoles and remove the authz prefix

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>

---------

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort the response from ListRoles
3 participants