Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamps for evaluation statuses have time zone. #3858

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Jul 11, 2024

Summary

There's no such thing as no timezone.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Manual tests.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@blkt blkt self-assigned this Jul 11, 2024
@blkt blkt requested a review from a team as a code owner July 11, 2024 09:10
There's no such thing as no timezone.
@blkt blkt force-pushed the fix-no-such-thing-no-timezone branch from 9425f6d to 6ce732b Compare July 11, 2024 09:11
@coveralls
Copy link

coveralls commented Jul 11, 2024

Coverage Status

coverage: 53.077% (-0.005%) from 53.082%
when pulling 6ce732b on fix-no-such-thing-no-timezone
into a5b4d9b on main.

@blkt blkt merged commit ca2c6cf into main Jul 11, 2024
21 checks passed
@blkt blkt deleted the fix-no-such-thing-no-timezone branch July 11, 2024 10:49
dmjb pushed a commit that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants