Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Version 2 config for sqlc.yaml #3861

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Use Version 2 config for sqlc.yaml #3861

merged 1 commit into from
Jul 11, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jul 11, 2024

This makes it easier to reuse examples from the documentation.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This makes it easier to reuse examples from the documentation.
@dmjb dmjb requested a review from a team as a code owner July 11, 2024 11:23
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make gen doesn't produce any diff -> good

@coveralls
Copy link

Coverage Status

coverage: 53.056% (+0.004%) from 53.052%
when pulling d3909a5 on sqlc-2.0-config
into a441c32 on main.

@dmjb dmjb merged commit b80f3aa into main Jul 11, 2024
23 of 24 checks passed
@dmjb dmjb deleted the sqlc-2.0-config branch July 11, 2024 11:34
dmjb added a commit that referenced this pull request Jul 12, 2024
This makes it easier to reuse examples from the documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants