Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with mapping of TIMESTAMPZ[] postgres type #3863

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Fix issues with mapping of TIMESTAMPZ[] postgres type #3863

merged 1 commit into from
Jul 11, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jul 11, 2024 •
edited
Loading

Prior to this PR, sqlc was unable to map TIMESTAMPZ[] to []time.Time due a limitation in the pq driver. This PR leverages a suggested fix from a Github issue in the pq repo.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@dmjb dmjb requested a review from a team as a code owner July 11, 2024 12:07
@dmjb
Fix issues with mapping of TIMESTAMPZ[] postgres type
f25115c 
Prior to this PR, sqlc was unable to map `TIMESTAMPZ[]` to `[]time.Time`
due a limitation in the `pq` driver. This PR leverages a suggested fix
from a Github issue in the `pq` repo.
@dmjb dmjb merged commit 546457c into main Jul 11, 2024
19 checks passed
@dmjb dmjb deleted the timearray-mapping branch July 11, 2024 12:16
@coveralls
Copy link

Coverage Status

coverage: 53.047%. remained the same
when pulling f25115c on timearray-mapping
into b80f3aa on main.

dmjb added a commit that referenced this pull request Jul 12, 2024
@dmjb
Fix issues with mapping of TIMESTAMPZ[] postgres type (#3863)
1ee0b5f 
Prior to this PR, sqlc was unable to map `TIMESTAMPZ[]` to `[]time.Time`
due a limitation in the `pq` driver. This PR leverages a suggested fix
from a Github issue in the `pq` repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blkt blkt blkt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmjb @coveralls @blkt